Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s 1.16 compability - bump kube-scheduler, kubespawner, kubernetes python client, oauthenticator #1483

Merged
merged 8 commits into from
Nov 28, 2019

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 16, 2019

  1. Make kubespawner function for k8s 1.16
  2. Bump kube-scheduler
    If I don't bump kube-scheduler, I note that the scheduler stop working in k8s 1.16. I'm not sure why. Anyhow, I bump various versions at the moment to see what works and doesn't work. We are bumping from kube-scheduler v1.11.2 in use by user-scheduler, which is just a configured kube-scheduler. These are the available images.
    • Using 1.16.3 on k8s 1.13-1.15 failed with pending user pods never being scheduled and for k8s 1.16 It is untested yet.
    • Using 1.13.12 on k8s 1.13-1.16 succeeded!
  3. Bump kubespawner
    • Tested against kubespawner PR
    • Merged Kubespawner PR
    • Made a kubespawner release
    • Referenced the kubespawner release
  4. Get things to work with dependencies etc.
    • Bump of kubernetes client to include a security fix forced some additional bumping, and while trying to get it right I also included the oauthenticator release bump.

Perhaps there are more things needed to be done, but I think all known issues are now addressed.

Closes #1444 entirely, see: #1444 (comment).

@consideRatio consideRatio changed the title [WIP] Kubernetes 1.16 compability [WIP] k8s 1.16 compability - bump user-scheduler and kubespawner Nov 16, 2019
@consideRatio consideRatio changed the title [WIP] k8s 1.16 compability - bump user-scheduler and kubespawner [WIP] k8s 1.16 compability - bump kube-scheduler and kubespawner Nov 16, 2019
@consideRatio consideRatio changed the title [WIP] k8s 1.16 compability - bump kube-scheduler and kubespawner [BLOCKED by kubespawner] k8s 1.16 compability - bump kube-scheduler and kubespawner Nov 16, 2019
@manics
Copy link
Member

manics commented Nov 18, 2019

Presumably when 1.16 is fixed you can remove allow_failure?

- &allow_failure Z2JH_KUBE_VERSION=1.16.2

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/binder-jupyterhub-activity-round-up-week-1/2704/1

@jess-sol
Copy link

It'd be nice if in the meantime the kubeVersion was modified to ~1.14.0-0, so it doesn't catch other people off-guard.

This was required for the pods to not get stuck in pending on k8s 1.16,
I'm not sure what changes but hey we were using a k8s 1.11
user-scheduler image along with k8s 1.16 after all...
@consideRatio consideRatio changed the title [BLOCKED by kubespawner] k8s 1.16 compability - bump kube-scheduler and kubespawner k8s 1.16 compability - bump kube-scheduler, kubespawner, kubernetes python client Nov 28, 2019
@consideRatio
Copy link
Member Author

Hmmmm... Trying and failing to pull image?

Error from server (BadRequest): container "hub" in pod "hub-596d84c66d-s2mw6" is waiting to start: trying and failing to pull image

@consideRatio
Copy link
Member Author

consideRatio commented Nov 28, 2019

The unexpected path stuff I experienced in the CI system relates to https://github.com/kubernetes-sigs/kind/releases/tag/v0.6.0 breaking changes regarding KUBECONFIG.

@consideRatio consideRatio merged commit 7727fe0 into jupyterhub:master Nov 28, 2019
@consideRatio consideRatio changed the title k8s 1.16 compability - bump kube-scheduler, kubespawner, kubernetes python client k8s 1.16 compability - bump kube-scheduler, kubespawner, kubernetes python client, oauthenticator Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.16 compatibility
4 participants