Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump to base-notebook with JH 1.1.0 etc #1588

Merged
merged 2 commits into from
Mar 22, 2020

Conversation

bitnik
Copy link
Contributor

@bitnik bitnik commented Feb 27, 2020

#1549 bumps jupyter/base-notebook:d4e60350af15 which has jhub 1.0.0 installed (https://hub.docker.com/r/jupyter/base-notebook/tags/?page=2), but because in Dockerfile pip install --upgrade jupyterhub is executed, at the end image has jhub 1.1.0.

Since jupyter/docker-stacks#992 is fixed, we can use the latest jupyter/base-notebook and dont have to manually upgrade jhub anymore.

@consideRatio
Copy link
Member

We don't have to manually do it now, but will need to do that whenever there is a minor release or anything on JupyterHub before it has been merged in docker-stacks. I think I prefer to retain the update step to ensure we are always up to date with JupyterHub like we are quick to be in the hub image.

+1 on bumping the base-notebook tag, but could we retain the manual upgrade step of jupyterhub? I find it convenient with a very little drawback of potentially increasing the image size, I'm not sure.

@bitnik
Copy link
Contributor Author

bitnik commented Mar 3, 2020

Hmm I understand your point. Then maybe we should upgrade it to JUPYTERHUB_VERSION
as we do in hub's dockerfile. What do you think?

We already have JUPYTERHUB_VERSION defined in chartpress.yaml:

singleuser-sample:
valuesPath: singleuser.image
buildArgs:
JUPYTERHUB_VERSION: 1.1.0

@consideRatio
Copy link
Member

Yepp that sounds good to me @bitnik!

@consideRatio consideRatio merged commit a5127ae into jupyterhub:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants