Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional liveness and readiness probe properties #1767

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Add additional liveness and readiness probe properties #1767

merged 1 commit into from
Sep 3, 2020

Conversation

rmoe
Copy link
Contributor

@rmoe rmoe commented Sep 3, 2020

This allows one to set failureThreshold and timeoutSeconds for the hub probes.

Related: #1732

@rmoe
Add additional liveness and readiness probe properties
5bd6cbc 
This allows one to set failureThreshold and timeoutSeconds
for the hub probes.

Related: jupyterhub#1732
@welcome
Copy link

welcome bot commented Sep 3, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

consideRatio commented Sep 3, 2020 •
edited
Loading

The provided default values in values.yaml are also the k8s default values, so this should not make any difference other than getting a bit more explicit output which now can be configured. LGTM - thanks for the PR @rmoe!

As discussed in #1732, perhaps we want to increase the failure threshold significantly by default.

@consideRatio consideRatio merged commit 072ef05 into jupyterhub:master Sep 3, 2020
@welcome
Copy link

welcome bot commented Sep 3, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmoe @consideRatio