Add maintainers / owners to register with Artifact Hub #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the new Helm Hub apparently. I suggest others in the JupyterHub team that wants add themselves as well!
manics
reviewed
Oct 7, 2020
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
manics
reviewed
Oct 13, 2020
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
consideRatio
commented
Oct 17, 2020
| @@ -9,3 +11,8 @@ sources: | |||
| icon: https://jupyter.org/assets/hublogo.svg | |||
| kubeVersion: '>=1.11.0-0' | |||
| tillerVersion: '>=2.11.0-0' | |||
| maintainers: | |||
| - name: Erik Sundell | |||
There was a problem hiding this comment.
Suggested change
| - name: Erik Sundell | |
| # Since it is a requirement of Artifact Hub to have specific maintainers | |
| # listed, we have added some below, but in practice the entire JupyterHub team | |
| # contributes to the maintenance of this Helm chart. | |
| - name: Erik Sundell |
There was a problem hiding this comment.
@manics should we go ahead and add this comment and merge?
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
|
Might as well, people can add themselves later 😃 |
This was referenced Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to register with the distribution center for Helm charts: Artifact Hub. Helm Hub is automatically redirecting there now.
I suggest others in the @jupyterhub/jupyterhubteam that wants to add themselves here as owners/maintainers in the Chart.yaml as well, if not for you please do it for me so it doesn't look like the only maintainer in this collaborative project involving so many parts from the JupyterHub ecosystem!
This relates to #1517.