-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeSelector and tolerations config for all pods of Helm chart #1827
Add nodeSelector and tolerations config for all pods of Helm chart #1827
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
456b78a
to
ed2f787
Compare
This PR is related to, but does not fix #1486, which should be fixed in a separate PR. |
5ef7901
to
814e725
Compare
814e725
to
c519cce
Compare
Thank you @stevenstetzler for getting this started ❤️ 🎉! I made some adjustments to: a) align configuration with other chart configuration, b) test this with dummy values in our linting script, and c) document this configuration in schema.yaml. It would be reasonable to have a chart wide nodeSelector/nodeAffinity for core pods to some predefined label, and we already intend to have that, but we need to implement it correctly first - this is issue #1486. It would also be reasonable to have a similar chart wide toleration of some taint for core pods, but I don't want to push for that unless its clearly wanted by multiple people as it would add quite a bit of complexity as usual - mostly because augmenting values in Helm templates is a mess, and deprecations etc will make it become a terrible blob of code to maintain. |
This PR is meant to fix #1130