Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector and tolerations config for all pods of Helm chart #1827

Merged

Conversation

stevenstetzler
Copy link
Contributor

@stevenstetzler stevenstetzler commented Oct 9, 2020

This PR is meant to fix #1130

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

This PR is related to, but does not fix #1486, which should be fixed in a separate PR.

@consideRatio consideRatio changed the title added tolerations to all components of Helm chart Add tolerations config for all pods of Helm chart Oct 9, 2020
@consideRatio consideRatio changed the title Add tolerations config for all pods of Helm chart Add nodeSelector and tolerations config for all pods of Helm chart Oct 9, 2020
@consideRatio
Copy link
Member

Thank you @stevenstetzler for getting this started ❤️ 🎉! I made some adjustments to: a) align configuration with other chart configuration, b) test this with dummy values in our linting script, and c) document this configuration in schema.yaml.

It would be reasonable to have a chart wide nodeSelector/nodeAffinity for core pods to some predefined label, and we already intend to have that, but we need to implement it correctly first - this is issue #1486.

It would also be reasonable to have a similar chart wide toleration of some taint for core pods, but I don't want to push for that unless its clearly wanted by multiple people as it would add quite a bit of complexity as usual - mostly because augmenting values in Helm templates is a mess, and deprecations etc will make it become a terrible blob of code to maintain.

@consideRatio consideRatio merged commit 6e5ec7e into jupyterhub:master Oct 9, 2020
@welcome
Copy link

welcome bot commented Oct 9, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tolerations to everything!
2 participants