Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable resource requests for hook-image-awaiter #1906

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 11, 2020

For any user with a ResourceQuota installed and aggregate limits to all pods combined container requests/limits, we need to allow resources be set to being denied by the Admission webhook that comes with a ResourceQuota resource.

Example of error that can come from not having resources configured on a pod are...

jupyterhub 4m49s Warning FailedCreate job/hook-image-awaiter (combined from similar events): Error creating: pods "hook-image-awaiter-6mvsc" is forbidden: failed quota: jupyterhub-resourcequota: must specify limits.cpu,limits.memory,requests.cpu,requests.memory

Thank you @tirumerla for pointing this out!

Closes #1761 (again).

@consideRatio consideRatio merged commit 56eaff4 into jupyterhub:master Nov 11, 2020
@tirumerla
Copy link

For any user with a ResourceQuota installed and aggregate limits to all pods combined container requests/limits, we need to allow resources be set to being denied by the Admission webhook that comes with a ResourceQuota resource.

Example of error that can come from not having resources configured on a pod are...

jupyterhub 4m49s Warning FailedCreate job/hook-image-awaiter (combined from similar events): Error creating: pods "hook-image-awaiter-6mvsc" is forbidden: failed quota: jupyterhub-resourcequota: must specify limits.cpu,limits.memory,requests.cpu,requests.memory

Thank you @tirumerla for pointing this out!

Closes #1761 (again).

Thank you @consideRatio . Appreciate your quick help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to have resource requests/limits set on all our containers
2 participants