Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: full_namespace_report function improved #1967

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Dec 25, 2020

The full_namespace_report functioned defined in ci/common prints some useful output about the current k8s namespace using kubectl. This PR updates that function.

  1. We now always run it, it only takes 1 second for a local k3s cluster.
  2. We provide headers with nice colors, yellow / red depending on if the content to known to be associated with an error or not.
  3. I refactored the function a bit, removing xargs as it was hard to only print headers when a condition was met without duplicating a lot of code.

full-namespace-report

@consideRatio
Copy link
Member Author

consideRatio commented Dec 25, 2020

@manics btw, the beutify shell thing in pre-commit worked well to autoformat some indentation details just like black would! It has not been doing things that I felt was troublesome so far.

@consideRatio consideRatio merged commit bfcc26a into jupyterhub:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant