Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: default to maxUnavailable=1 instead of minAvailable=1 #2039

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Feb 17, 2021

If you want to lower the replicas of user-scheduler to 1, then you will get the same PDB issues we have had with hub/proxy (#1938) where they block upgrades etc because we have minAvailable: 1 instead of maxUnavailable: 1 in order to handle workloads.

jupyterhub/schema.yaml Outdated Show resolved Hide resolved
@yuvipanda
Copy link
Collaborator

So if we have 2 replicas, it will still ensure there will at least be one available, right?

@consideRatio
Copy link
Member Author

So if we have 2 replicas, it will still ensure there will at least be one available, right?

Yepp! Note btw that maxUnavailable was introduced in k8s 1.9 or something, which was later than the PDBs were introduced in the first place in z2jh.

@consideRatio
Copy link
Member Author

consideRatio commented Feb 17, 2021

image

Hmmmmm, perhaps did a mistake with the logic... It should show maxUnavailable there. Btw, this is from the CI system in the upgrade -> dev step, making a diff on the rendered templates since the last dev release.

@consideRatio
Copy link
Member Author

Omg, kindOf returns "float64" instead of "int", woops.

@consideRatio
Copy link
Member Author

consideRatio commented Feb 17, 2021

Okay finally got everything right, the tests did a great job helping me! ❤️

image

@yuvipanda yuvipanda merged commit 512af3e into jupyterhub:master Feb 18, 2021
@yuvipanda
Copy link
Collaborator

Thanks, @consideRatio!

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Feb 18, 2021
jupyterhub/zero-to-jupyterhub-k8s#2039 Merge pull request #2039 from consideRatio/pr/pdb-max-unavailable
@consideRatio
Copy link
Member Author

Thanks @yuvipanda for your help with review/merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants