Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update installation docs to refer to current latest version #2040

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

spenczar
Copy link
Contributor

This actually really kicked my butt. The way that authentication is configured was changed between 0.10.6 and 0.11.1; I couldn't figure out why my Jupyterhub instance would accept any user/password combo without complaining, and logs seemed to show that it just wasn't loading any of my configuration at all. This was very confusing!

It would be great if this version number could be tied in to the actual released version somehow, but I think that may be too much to ask - although I'm no sphinx expert, maybe it can be done.

It would also be great if unexpected configuration keys got a warning of some kind in logs. Wouldn't have helped here, but it will help for future changes to the way things are configured.

@welcome
Copy link

welcome bot commented Feb 17, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio consideRatio merged commit 7264248 into jupyterhub:master Feb 17, 2021
@welcome
Copy link

welcome bot commented Feb 17, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants