Update postgres db url dialect in schema docs#2105
Merged
Conversation
The `postgres` dialect is deprecated and has been removed in sqlalchemy 1.4, we should be using `postgresql` now. See the discussion in jupyterhub/jupyterhub#3383.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Mar 19, 2021
jupyterhub/zero-to-jupyterhub-k8s#2105 Merge pull request #2105 from mriedem/postgresql-dialect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
postgresdialect is deprecated and has been removedin sqlalchemy 1.4, we should be using
postgresqlnow. Seethe discussion in jupyterhub/jupyterhub#3383.