inline comment: info about the state used by prePuller.hook.pullOnlyOnChanges#2173
Merged
consideRatio merged 1 commit intojupyterhub:masterfrom May 4, 2021
Conversation
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 4, 2021
jupyterhub/zero-to-jupyterhub-k8s#2173 Merge pull request #2173 from consideRatio/pr/comment-for-insights-about-pullOnlyOnChanges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps debug an error observed by @yuvipanda related to the feature prePuller.hook.pullOnlyOnChanges that compares the checksum of the previously generated DaemonSet resource.
A comparison is made between two checksums, one that was stored from the last
helm install/upgradecommand in the hub ConfigMap, and one for the currenthelm install/upgrade. The checksum are for the hook-image-puller DaemonSet.This PR anyhow, just emits those strings and prints them in the
hook-image-awaiterJob and associated Pod.