Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prePuller.hook.pullOnlyOnChanges didn't work, now it does #2174

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 4, 2021

Closes #2172 by the strategy described in #2172 (comment).

In brief:

  1. the checksum of the hook-image-puller daemonset that was calculated became different based on from what template origin calculated the checksum as .Templates.Name changed which in turn influenced rendered labels.
  2. the checksum of the hook-image-puller daemonset that was calculated became different based on .Chart.Version as found in labels as well, which was irrelevant to re-pull on.
  3. the rbac resources used by hook-image-awaiter were created no matter what, but now they are created based on if the hook-image-awaiter job is created.

Note though that we do want to pull again if something has changed about node affinity etc, so instead of just creating a list of the images it makes sense to still use a checksum of the k8s resource with some parts omitted, like the labels in the metadata section.

@consideRatio consideRatio force-pushed the pr/fix-pullOnlyOnChanges-feature branch from 66cc831 to 198fc85 Compare May 4, 2021 22:08
@consideRatio consideRatio merged commit 17491c1 into jupyterhub:master May 4, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request May 4, 2021
jupyterhub/zero-to-jupyterhub-k8s#2174 Merge pull request #2174 from consideRatio/pr/fix-pullOnlyOnChanges-feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prePuller.hook.pullOnlyOnChanges not pulling only on changes
1 participant