Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix permissions of PR creating action #2186

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 10, 2021

    # Write permissions granted for the peter-evans/create-pull-request action
    # to push to a branch and create/update a PR
    permissions:
      contents: write
      pull-requests: write

Both ability to push to a branch and create/update pull requests is required for an action in the vuln-scan workflow. This PR fixes that. It also removes some inline comments that would become outdated quickly.

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/vuln-scan.yaml Show resolved Hide resolved
@manics
Copy link
Member

manics commented May 10, 2021

Thanks!

@manics manics merged commit 8a89aae into jupyterhub:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants