Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to set imagePullSecrets for user-placeholder pods (scheduling.userPlaceholder.image config added) #2293

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

michaellzc
Copy link
Contributor

@michaellzc michaellzc commented Jun 29, 2021

Updated summary by Erik

prePuller.pause.image.name|tag was used to set the user-placeholder pods image, but the user-placeholder pods didn't make use of the prePuller.pause.image.pullPolicy|pullSecrets or any other config to set imagePullPolicy or imagePullSecrets. With this PR the dedicated option scheduling.userPlaceholer.image and respective fields are added and respected for the user-placeholder pods.

Original PR summary

prePuller.pause.image.pullSecrets was already defined in values.yaml but it was never actually used in the placeholder statefulset template.

@welcome
Copy link

welcome bot commented Jun 29, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

It was quite weird that the prePuller.pause.image was used in userPlaceholder instead of scheduling.userPlaceholder.image, so I adjusted this PR that has a very valid point to instead of adding to the weird behavior - creating a dedicated configuration for the userPlaceholder image.

@consideRatio consideRatio changed the title fix: actually set imagepullsecrets in placeholder Fix failure to set imagePullSecrets for user-placeholder pods via scheduling.userPlaceholder.image config Jun 29, 2021
@consideRatio consideRatio changed the title Fix failure to set imagePullSecrets for user-placeholder pods via scheduling.userPlaceholder.image config Fix failure to set imagePullSecrets for user-placeholder pods by adding scheduling.userPlaceholder.image config Jun 29, 2021
@consideRatio
Copy link
Member

Thanks @michaellzc! I wanted to resolve this in a slightly different way, does it make sense to you? I pushed a commit and update the PR description.

@consideRatio consideRatio changed the title Fix failure to set imagePullSecrets for user-placeholder pods by adding scheduling.userPlaceholder.image config Fix failure to set imagePullSecrets for user-placeholder pods (scheduling.userPlaceholder.image config added) Jun 29, 2021
@michaellzc
Copy link
Contributor Author

Thanks @michaellzc! I wanted to resolve this in a slightly different way, does it make sense to you? I pushed a commit and update the PR description.

lgtm 👍

@consideRatio consideRatio merged commit faaa97e into jupyterhub:main Jun 29, 2021
@welcome
Copy link

welcome bot commented Jun 29, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants