Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress.pathType config #2305

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Add ingress.pathType config #2305

merged 2 commits into from
Jul 6, 2021

Conversation

jtrouth
Copy link
Contributor

@jtrouth jtrouth commented Jul 6, 2021

This adds the ability to set the pathType field on ingress rules for situations where Prefix is not available or appropriate, such as on GKE 1.19+ with the native ingress controller which only accepts 'ImplementationSpecific' as the pathType.

@welcome
Copy link

welcome bot commented Jul 6, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtrouth jtrouth changed the title Added value for ingress pathType Add value for ingress pathType Jul 6, 2021
@consideRatio consideRatio changed the title Add value for ingress pathType Add ingress.pathType config Jul 6, 2021
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtrouth and congrats on your first code contribution to this repo! ❤️ 🎉

@consideRatio consideRatio merged commit 28b8cbe into jupyterhub:main Jul 6, 2021
@welcome
Copy link

welcome bot commented Jul 6, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants