Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image-puller pods to evict user-placeholder pods #2681

Merged
merged 2 commits into from
May 6, 2022

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 5, 2022

I wanted to push a commit to #2574 but wasn't allowed to, due to that I decided to open a new PR built on top of #2574. @a3626a is this okay with you?

I've rebased @a3626a's commit from #2574 and added another commit with changes I wanted to see.

Summary

This PR adds another PriorityClass resource that [hook|continuous]-image-puller pods can reference in order to acquire a priority making them considered more important than user placeholder pods but still not more important than normal user pods. In practice, this resolves a bug where we could have too many user placeholder pods to fit a image-puller pod and end up with a node that didn't get their image pre-pulled for users.

I labelled it as a bugfix, its kind of a new feature as well - intended to fix a bug in behavior.

@a3626a
Copy link
Contributor

a3626a commented May 6, 2022

I wanted to push a commit to #2574 but wasn't allowed to, due to that I decided to open a new PR built on top of #2574. @a3626a is this okay with you?

Of course. Thank you

@yuvipanda
Copy link
Collaborator

Thanks a lot, @consideRatio and @a3626a!!!

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants