Enable image-puller pods to evict user-placeholder pods#2681
Merged
Conversation
Contributor
Collaborator
|
Thanks a lot, @consideRatio and @a3626a!!! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 6, 2022
jupyterhub/zero-to-jupyterhub-k8s#2681 Merge pull request #2681 from consideRatio/tmpimgpull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to push a commit to #2574 but wasn't allowed to, due to that I decided to open a new PR built on top of #2574. @a3626a is this okay with you?
I've rebased @a3626a's commit from #2574 and added another commit with changes I wanted to see.
Summary
This PR adds another PriorityClass resource that [hook|continuous]-image-puller pods can reference in order to acquire a priority making them considered more important than user placeholder pods but still not more important than normal user pods. In practice, this resolves a bug where we could have too many user placeholder pods to fit a image-puller pod and end up with a node that didn't get their image pre-pulled for users.
I labelled it as a bugfix, its kind of a new feature as well - intended to fix a bug in behavior.