Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singleuser.allowPrivilegeEscalation for KubeSpawner 2+ #2713

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented May 18, 2022

I could not push to #2663 so I'm opening this PR to complement it with required parts. Closes #2663, ping @snickell!


I'm a bit unhappy about adding another dedicated passthrough config to the helm chart, but I'm also afraid of the work to champion the use of hub.config.KubeSpawner at this point. I'm afraid of the effort to clarify what can and can't be set there without trouble. Some configuration has been used both by helm chart templates, and by the jupyterhub_config.py file, and that config must still be read from the dedicated config values etc.

@consideRatio consideRatio force-pushed the pr/add-singleuser-allowPrivilegeEscalation branch from 71b30ab to 86f42cc Compare May 18, 2022 18:10
@consideRatio consideRatio force-pushed the pr/add-singleuser-allowPrivilegeEscalation branch from 86f42cc to 95c6f0a Compare May 18, 2022 18:12
@yuvipanda yuvipanda merged commit 6de894c into jupyterhub:main May 18, 2022
@yuvipanda
Copy link
Collaborator

Thanks, @consideRatio!

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request May 18, 2022
jupyterhub/zero-to-jupyterhub-k8s#2713 Merge pull request #2713 from consideRatio/pr/add-singleuser-allowPrivilegeEscalation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants