Add singleuser.allowPrivilegeEscalation for KubeSpawner 2+#2713
Merged
yuvipanda merged 2 commits intoMay 18, 2022
Merged
Conversation
consideRatio
force-pushed
the
pr/add-singleuser-allowPrivilegeEscalation
branch
from
71b30ab to
86f42cc
Compare
consideRatio
force-pushed
the
pr/add-singleuser-allowPrivilegeEscalation
branch
from
86f42cc to
95c6f0a
Compare
Collaborator
|
Thanks, @consideRatio! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 18, 2022
jupyterhub/zero-to-jupyterhub-k8s#2713 Merge pull request #2713 from consideRatio/pr/add-singleuser-allowPrivilegeEscalation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not push to #2663 so I'm opening this PR to complement it with required parts. Closes #2663, ping @snickell!
I'm a bit unhappy about adding another dedicated passthrough config to the helm chart, but I'm also afraid of the work to champion the use of hub.config.KubeSpawner at this point. I'm afraid of the effort to clarify what can and can't be set there without trouble. Some configuration has been used both by helm chart templates, and by the jupyterhub_config.py file, and that config must still be read from the dedicated config values etc.