Fix for PDBs in k8s 1.20#2727
Merged
consideRatio merged 2 commits intoMay 29, 2022
Merged
Conversation
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 29, 2022
jupyterhub/zero-to-jupyterhub-k8s#2727 Merge pull request #2727 from consideRatio/pr/fix-for-pdbs-in-k8s-1.20
|
@consideRatio - apologies I never got around to creating a PR for this! Flagged the email to do it and seen that you already had! Thanks! Much appreciated 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2649 as reported by @geoffo-dev, where policy/v1 seems to be available in the k8s cluster event though policy/v1 PodDisruptionBudgets only come around in k8s 1.21.
I was on track to get this done across other repos, and went along and did it also for this repo. The actual work was not making the PR, it was to realize there is a bug like this. Thank you @geoffo-dev!