Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable commands when no formatter supported #4

Closed
jtpio opened this issue Nov 30, 2018 · 1 comment · Fixed by #25
Closed

Disable commands when no formatter supported #4

jtpio opened this issue Nov 30, 2018 · 1 comment · Fixed by #25

Comments

@jtpio
Copy link
Member

jtpio commented Nov 30, 2018

Commands stay enabled for every file type / document currently open, which can be confusing.

Example with json files:

image

The idea would be disable them when they can't be used.
@ryantam626
Copy link
Collaborator

Ah yes, this was left as a TODO in the code and I never got around finishing it 🙈

@jtpio jtpio changed the title Disable commands when not formatter supported Disable commands when no formatter supported Dec 2, 2018
This was referenced May 7, 2019
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the commands visible for Python files and notebooks only jtpio/jupyterlab_code_formatter
2 participants
@jtpio @ryantam626