Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for nteract data explorer #10

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@saulshanabrook
Copy link
Member

commented Apr 11, 2019

This PR adds a Table Data schema mimerender and adds nteract Data Explorer support for this format:

The current flow is to enable table data output from pandas, output a dataframe, and then click "nteract Data Explorer" on the tmp:/// dataset:

Screen Shot 2019-04-11 at 2 40 17 PM

This is more a POC than a recommendation for the final UX. Couple of UX questions:

  1. Should we render the data explorer inline in the output as we do for other mimetype renderers? We could also register it with the data registry. We would need to add a tab bar to the output, if there are multiple valid viewers for some mimetype
  2. Ideally I think we could name the URL like notebook://<path>/<to>/<notebook>.ipynb; cell=<cell #>.<output #> to uniquely identify a cell output. I don't think the current rendermime system gives the output enough information to create this URL. You don't know which notebook you are in or what cell is outputting. (EDIT: You can do this, by looking at the parent of the renderer widget repeatedly to get up to the notebook and cell model. From there you can tell which cell it is and the path of the notebook.
@saulshanabrook

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Another idea for integrating this existing rendermine extensions:

  1. Query existing mimerender extensions and add them all to the data registry.
  2. Add new mimerender extension that renders via data registry and targets all mimetypes. Now all outputs will be registered with data registry. Also, have it render the default viewer inline, so it works similarly inside the notebook.
@saulshanabrook

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

I am going to merge this in, then we can iterate on it.

@saulshanabrook saulshanabrook merged commit 333a31e into master Apr 23, 2019

@saulshanabrook saulshanabrook deleted the nteract-data-explorer branch Jul 27, 2019

@saulshanabrook saulshanabrook restored the nteract-data-explorer branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.