Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks with - in filenames get wrapped in the Running list #1611

Closed
ellisonbg opened this issue Feb 5, 2017 · 5 comments · Fixed by #1668
Closed

Notebooks with - in filenames get wrapped in the Running list #1611

ellisonbg opened this issue Feb 5, 2017 · 5 comments · Fixed by #1668
Assignees
@blink1073
Labels
bug pkg:running status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
0.31.0

Comments

@ellisonbg
Copy link
Contributor

screen shot 2017-02-05 at 11 35 13 am
@ellisonbg ellisonbg added this to the Beta milestone Feb 5, 2017
@ellisonbg ellisonbg mentioned this issue Feb 6, 2017
Merged
@ellisonbg
Copy link
Contributor Author

This is partially fixed by #1625

But names with - still don't get the hyphens.

@blink1073
Copy link
Member

This is what I'm seeing on master, is this not correct?

image

image

@ellisonbg
Copy link
Contributor Author

almost ;-)

Here are two files in the same dir, with almost the same name (- versus no -). You can see how they are displayed differently:

screen shot 2017-02-08 at 5 33 22 pm

screen shot 2017-02-08 at 5 33 29 pm

The filename without the - shows the last portion of the file, including the .ipynb. The version with the dashes cuts the filename at some point, only showing the beginning of the filename.

@ellisonbg
Copy link
Contributor Author

The part that I did fix is that the - filenames no longer wrap to multiple lines...

@blink1073
Copy link
Member

What does a name with spaces do? I can check in the morning.

@blink1073 blink1073 mentioned this issue Feb 9, 2017
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blink1073 blink1073

Labels
bug pkg:running status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Fix the rendering of files with whitespace and hyphens blink1073/jupyterlab
2 participants
@ellisonbg @blink1073