Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of new renderer interface #1763

Closed
gnestor opened this issue Feb 21, 2017 · 6 comments
Closed

Documentation of new renderer interface #1763

gnestor opened this issue Feb 21, 2017 · 6 comments

Comments

@gnestor
Copy link
Contributor

@gnestor gnestor commented Feb 21, 2017

#1709 introduces a new interface for renderers. I've browsed through this PR but I haven't been able to adapt the mimerender extensions to work with this new interface (if an incompatible extension is enabled, I see Unable to render data in all of the output areas). Can we document the breaking changes here or can someone submit a PR to https://github.com/jupyterlab/jupyterlab_json to demonstrate how to use the new interface?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 21, 2017

Sure, I can do both after we get #1762 done.

@blink1073 blink1073 self-assigned this Feb 21, 2017
@blink1073 blink1073 added this to the Beta milestone Feb 21, 2017
@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 22, 2017

cf jupyter-attic/jupyterlab_json#19

Summary of changes:

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 22, 2017

Also note how much easier it is to create the default rendermime.

@gnestor
Copy link
Contributor Author

@gnestor gnestor commented Feb 22, 2017

@blink1073 Thanks so much! I got all of that except for the new addRenderer signature (which explains the Unable to render data error that I was seeing). Is there a way to specify a renderer's index anymore? Or is that no longer necessary?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 22, 2017

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 22, 2017

Closing as answered, please feel free to reopen if you disagree.

@blink1073 blink1073 closed this Feb 22, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants