Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the repository into multiple packages #1773

Closed
blink1073 opened this issue Feb 23, 2017 · 8 comments · Fixed by #1934
Closed

Split the repository into multiple packages #1773

blink1073 opened this issue Feb 23, 2017 · 8 comments · Fixed by #1934

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 23, 2017

This issue signals the intent to split the repository up into multiple packages in the same repository, following the example of phosphor.

Having independent packages allows them to be separately required by downstream consumers.

It is also a required step to enable plugin bundles to contain the entire package that they require, allowing us to treat each package as a unit when de-duplicating the final bundle.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 24, 2017

I propose a new repository called coreutils that is used by services as well.

It would contain:
Url, Ajax, and Config namespaces from @jupyterlab/services
ActivityMonitor, Dates, Sanitizer namespaces from src/common.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 27, 2017

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 27, 2017

I decided to leave ActivityMonitor and Sanitizer out because they are display-related. I also added a Path namespace and renamed Date -> Time.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 1, 2017

Coreutils is done, I ended up putting ActivityMonitor in there. We should decide on Friday where it should live (here or in its own repo).

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 3, 2017

Core utils and Dom utils are ready for incorporation pending today's dev meeting:

https://github.com/blink1073/coreutils
https://github.com/blink1073/domutils

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 7, 2017

Current plan:

Top level packages:

  • apputils - parts of common, commandlinker, instancetracker, instancerestorer, statedb, mainmenu
  • coreutils - parts of common, eventually services utils

Make the existing plugins packages in plugins/plugin-foo.
Make shortcuts and commandpalette plugins only.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 7, 2017

We can leave services in its own repo for now, but it needs to provide a token.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 7, 2017

The plan is to implement the folder structure in place with relative imports, and then switch over to Lerna.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant