Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
This issue signals the intent to split the repository up into multiple packages in the same repository, following the example of phosphor.
Having independent packages allows them to be separately required by downstream consumers.
It is also a required step to enable plugin bundles to contain the entire package that they require, allowing us to treat each package as a unit when de-duplicating the final bundle.
The text was updated successfully, but these errors were encountered:
I propose a new repository called coreutils that is used by services as well.
It would contain:
Url, Ajax, and Config namespaces from @jupyterlab/services
ActivityMonitor, Dates, Sanitizer namespaces from src/common.
Sorry, something went wrong.
Core utils wip: https://github.com/blink1073/coreutils.
I decided to leave ActivityMonitor and Sanitizer out because they are display-related. I also added a Path namespace and renamed Date -> Time.
Coreutils is done, I ended up putting ActivityMonitor in there. We should decide on Friday where it should live (here or in its own repo).
Core utils and Dom utils are ready for incorporation pending today's dev meeting:
Top level packages:
Make the existing plugins packages in plugins/plugin-foo.
Make shortcuts and commandpalette plugins only.
We can leave services in its own repo for now, but it needs to provide a token.
The plan is to implement the folder structure in place with relative imports, and then switch over to Lerna.
Successfully merging a pull request may close this issue.