Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description lists dl/dd/dt style differs #2399

Closed
Carreau opened this issue Jun 7, 2017 · 8 comments · Fixed by #5682
Closed

Description lists dl/dd/dt style differs #2399

Carreau opened this issue Jun 7, 2017 · 8 comments · Fixed by #5682

Comments

@Carreau
Copy link
Contributor

@Carreau Carreau commented Jun 7, 2017

This is a cross-frontend issue, but the styling of description lists is widely different depending on the frontend. Eg Lab/Classic/Nteract.

screen shot 2017-06-07 at 16 53 20

It would be good to have (some) coherence. The Classic Notebook.seem to be the worse right now.

cc @rgbkrk and @gnestor

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jun 8, 2017

I may have gone a little overboard because I wanted definition lists to appear beautiful inline, especially when there are nested elements. How it turned out I have no idea.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 8, 2017

Could you grab the raw HTML output of that to use for testing and iterating on design? Or do you have other examples to design for?

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jun 8, 2017

    <div>
        <p><b>SparkContext</b></p>

        <p><a href="http://10.0.0.169:4040">Spark UI</a></p>

        <dl>
          <dt>Version</dt>
            <dd><code>v2.1.1</code></dd>
          <dt>Master</dt>
            <dd><code>local[*]</code></dd>
          <dt>AppName</dt>
            <dd><code>pyspark-shell</code></dd>
        </dl>
    </div>

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 8, 2017

@jasongrout jasongrout removed this from the 1.0 milestone Sep 5, 2018
@jasongrout jasongrout added this to the 1.0 milestone Sep 6, 2018
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 6, 2018

We should at least verify that our current styling is what we want for 1.0, especially when compared to classic, since it might change how people's markdown looks.

@gnestor
Copy link
Contributor

@gnestor gnestor commented Sep 14, 2018

Aesthetically, I prefer nteract's styling.

I think that we should just take a vote here and update the other clients accordingly.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 14, 2018

I also like the nteract styling best.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 14, 2018

Of the three options in the screenshots, I like the nteract styling the best.

@gnestor gnestor self-assigned this Sep 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants