Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability of (double) mouse clicks on command palette #279

Closed
Carreau opened this issue Jul 9, 2016 · 7 comments
Closed

Usability of (double) mouse clicks on command palette #279

Carreau opened this issue Jul 9, 2016 · 7 comments

Comments

@Carreau
Copy link
Contributor

@Carreau Carreau commented Jul 9, 2016

That's definitively a user bug (PEBKAC), so I'm to blame. But I guess I won't be the only one.

I think that this might be because for selected item, the appearance is not different on :hover, and that having an extra-highlight or underline on hover will partly help my brain adjust and click only once.
Still I might (often) keep trigger the action twice, which might be undesirable.

Do you think it could be a good idea to also bind double-click as well, to prevent this kind of things ?

@ellisonbg ellisonbg changed the title I'm can't help, I double click on Command Palette items. Usability of (double) mouse clicks on command palette Aug 25, 2016
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Aug 25, 2016

To clarify, right now command palette actions are triggered on single clicks. The way it works currently, a double click then triggers the actions twice which is not usually what the user wanted. We should look at UI/UX changes to better indicate that it is single, not double click to trigger the action.

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Oct 2, 2018

@Carreau Do you think if we incorporated the suggested solution to #1095 it would prevent this type of mistake? For reference I suggested that we give visual indication when a command palette item is pressed by changing from UI color 2 to UI color 3 on active. Same like we do for buttons.

@Carreau
Copy link
Contributor Author

@Carreau Carreau commented Oct 2, 2018

It will likely help, but is probably more complicated than just having a style change with CSS. (or maybe you can do it with CSS ? )

Also we should consider how this will affect users of keyboard.

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Oct 11, 2018

Keyboard focus is UI color 3 as well, if we use ui color 3 on activate, it would already be present for focus, might need to 'blink' the background on activate to give the same active signal to keyboard users.

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Dec 19, 2018

I think we should merge and iterate on the above idea. @saulshanabrook do you have time to help me execute this?

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 22, 2019

From @blink1073 - maybe we need to debounce to the double click does have the negative side effect.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants