Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style datagrid appropriately for dark theme #3456

Closed
ellisonbg opened this issue Dec 21, 2017 · 0 comments · Fixed by #5304
Closed

Style datagrid appropriately for dark theme #3456

ellisonbg opened this issue Dec 21, 2017 · 0 comments · Fixed by #5304
Assignees
@ian-r-rose
Labels
pkg:csvviewer pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone
1.0

Comments

@ellisonbg
Copy link
Contributor

The datagrid doesn't use CSS for styling and thus is currently isn't styled appropriately in the dark them. See also #3454.
@ellisonbg ellisonbg added this to the 1.0 milestone Dec 21, 2017
@ellisonbg ellisonbg mentioned this issue Dec 21, 2017
Closed
@jasongrout jasongrout removed this from the 1.0 milestone Sep 5, 2018
@ian-r-rose ian-r-rose added this to the 1.0 milestone Sep 6, 2018
@ian-r-rose ian-r-rose mentioned this issue Sep 12, 2018
Merged
@blink1073 blink1073 mentioned this issue Sep 28, 2018
Closed
31 tasks
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ian-r-rose ian-r-rose

Labels
pkg:csvviewer pkg:themes status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Dark csv viewer ian-r-rose/jupyterlab
3 participants
@ellisonbg @jasongrout @ian-r-rose