Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Dirty status indication #3652

Closed
jasongrout opened this issue Jan 16, 2018 · 6 comments · Fixed by #3662
Closed

File Dirty status indication #3652

jasongrout opened this issue Jan 16, 2018 · 6 comments · Fixed by #3662

Comments

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 16, 2018

I thought at one time there was some visible difference in a tab of a document that was dirty (i.e., not saved). It seems that the visible difference is gone now - I can't tell how to see if a file needs to be saved.

For example, we could prefix the document name with *, or VS Code changes the close X to a filled circle.

@jasongrout jasongrout added this to the Beta 2 milestone Jan 16, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 17, 2018

It looks like this is currently broken for text files. I still see the filled circle for notebooks with unsaved changes, though.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 17, 2018

I didn't realize it was working for notebooks. I can look into this...

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 17, 2018

I'm diving down - as best as I can tell, the file title changed signal has no listeners, but the notebook title changed signal has the tab bar as a listener. Diving deeper...

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 17, 2018

heh, looks like you fixed it...

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 17, 2018

Yeah, sorry to step on your toes! A refactor put the jp-mod-dirty css class on the wrong div.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jan 17, 2018

oh, that easy!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants