Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close without saving dialog even when no changes #3706

Closed
dhirschfeld opened this issue Jan 24, 2018 · 10 comments · Fixed by #5622
Closed

Close without saving dialog even when no changes #3706

dhirschfeld opened this issue Jan 24, 2018 · 10 comments · Fixed by #5622

Comments

@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Jan 24, 2018

When I try and close a file which I've just opened and has no changes I still see the "Close without saving" dialog:

image

python 3.6.4
jupyterlab 0.31.1

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 24, 2018

@dhirschfeld I can't reproduce this on v0.31.1 or on master. Can you think of anything unusual about your setup?

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Jan 24, 2018

It's running in a Windows Container. Also that file was from a git repo - can't see that that could affect it tho

Wondering how I can debug further?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 24, 2018

I suspect this will be fixed in the process of fixing #3495

@blink1073 blink1073 added this to the Beta 2 milestone Feb 1, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 5, 2018

On second thought, I think the issue here is that the file endings might have changed. When you open the file, does the close icon in that tab change to a filled circle?

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Mar 6, 2018

On holiday so prob can't check for a couple of weeks. If I forget to update this issue feel free to ping me again here...

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 15, 2018

Bumping to beta 3. @dhirschfeld - if you can ping back when you're ready to move forward, that would be great!

@jasongrout jasongrout removed this from the Beta 2 milestone Mar 15, 2018
@jasongrout jasongrout added this to the Beta 3 milestone Mar 15, 2018
@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Apr 3, 2018

Looks like it is a line ending thing. As soon as I open it the line endings are changed and if I then save it git thinks it's modified. You can see the line endings changing in the before and after Get-Content calls below:

image

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Apr 3, 2018

Also, after saving the "unsaved indicator" doesn't reflect the fact that the file has been saved:
image

After saving the dialog doesn't pop up and git does show the changed content so you know the save did in fact take place even though the indicator didn't pick up that fact

@jasongrout jasongrout removed this from the Beta 3 milestone Apr 18, 2018
@jasongrout jasongrout added this to the Beta 2 Patch milestone Apr 18, 2018
@jasongrout jasongrout removed this from the Minor release milestone Apr 28, 2018
@jasongrout jasongrout added this to the Beta 3 milestone Apr 28, 2018
@jasongrout jasongrout removed this from the Beta 3 milestone Jun 27, 2018
@jasongrout jasongrout added this to the Beta 4 milestone Jun 27, 2018
@blink1073 blink1073 removed this from the 0.34 milestone Aug 13, 2018
@blink1073 blink1073 added this to the 0.35 milestone Aug 13, 2018
@blink1073 blink1073 removed this from the 0.35 milestone Sep 5, 2018
@blink1073 blink1073 added this to the 1.0 milestone Sep 5, 2018
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 26, 2018

This may be the CRLF issue: #3901

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Sep 26, 2018

Looks like it. I don't think there's any extra info here so feel free to close this as a dup if you want to keep the discussion in one place and minimise issue noise.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants