Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
When I try and close a file which I've just opened and has no changes I still see the "Close without saving" dialog:
The text was updated successfully, but these errors were encountered:
@dhirschfeld I can't reproduce this on v0.31.1 or on master. Can you think of anything unusual about your setup?
Sorry, something went wrong.
It's running in a Windows Container. Also that file was from a git repo - can't see that that could affect it tho
Wondering how I can debug further?
I suspect this will be fixed in the process of fixing #3495
On second thought, I think the issue here is that the file endings might have changed. When you open the file, does the close icon in that tab change to a filled circle?
On holiday so prob can't check for a couple of weeks. If I forget to update this issue feel free to ping me again here...
Bumping to beta 3. @dhirschfeld - if you can ping back when you're ready to move forward, that would be great!
Looks like it is a line ending thing. As soon as I open it the line endings are changed and if I then save it git thinks it's modified. You can see the line endings changing in the before and after Get-Content calls below:
Also, after saving the "unsaved indicator" doesn't reflect the fact that the file has been saved:
After saving the dialog doesn't pop up and git does show the changed content so you know the save did in fact take place even though the indicator didn't pick up that fact
This may be the CRLF issue: #3901
Looks like it. I don't think there's any extra info here so feel free to close this as a dup if you want to keep the discussion in one place and minimise issue noise.
Successfully merging a pull request may close this issue.