Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal scrollback increase? #3985

Closed
bubthegreat opened this issue Feb 23, 2018 · 5 comments · Fixed by #5609
Closed

Terminal scrollback increase? #3985

bubthegreat opened this issue Feb 23, 2018 · 5 comments · Fixed by #5609

Comments

@bubthegreat
Copy link

@bubthegreat bubthegreat commented Feb 23, 2018

Using jupyterlab as a development environment for log analysis scripting, I'm running into an issue with the terminal where it doesn't have a settings tab, so I'd have to manually go into the code (if possible) and change it there.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Apr 27, 2018

Thanks for the feedback. I can't find where we even set the max terminal scrollback, but this makes sense as something that should be configurable for the user.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 27, 2018

Here's a mention of setting the scrollback buffer size: xtermjs/xterm.js#518

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Apr 27, 2018

So this could be added to the terminal widget options: https://github.com/jupyterlab/jupyterlab/blob/master/packages/terminal/src/widget.ts and used to set the xterm option.

And either add a command to change the scrollback size or create settings for the terminal extension and use those

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 27, 2018

+1 to settings, -1 to a command. This is something I imagine people will set once, rather than keep changing.

@DevOpsChris
Copy link

@DevOpsChris DevOpsChris commented Jul 14, 2018

I'll take a stab at this for SciPy2018 Sprint.

@saulshanabrook saulshanabrook added this to the Future milestone Sep 10, 2018
@afshin afshin added DISC2018 and removed DISC2018 labels Oct 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants