Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Reload Editor Contents from Disk #4154

Closed
cancan101 opened this issue Mar 8, 2018 · 4 comments
Closed

Ability to Reload Editor Contents from Disk #4154

cancan101 opened this issue Mar 8, 2018 · 4 comments
Labels
enhancement good first issue pkg:docmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@cancan101
Copy link

If the user knows that the contents of a file have changed externally and wants to cause the editor to reload contents from disk. Right now this can be accomplished by trying to save a modified buffer and choosing "revert".

@gsemet
Copy link

gsemet commented Mar 8, 2018

That would be cool indeed !

@ian-r-rose
Copy link
Member

I think this is a good idea (and not just for editors). It should be possible to add a new command in docmanager-extension that calls docmanager.revert(), and add that to the file menu and the command palette.

Marking this as a good first issue.

@kcramer
Copy link
Contributor

kcramer commented May 21, 2018

This enhancement looked straightforward so I made the change and submitted a PR for it: #4615. There is an existing menu item Revert which is similar but calls restoreCheckpoint() and not just revert(). Is there any concern these two menu items could be confusing?

@ian-r-rose
Copy link
Member

Fixed by #4615

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement good first issue pkg:docmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants