Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable scrolling #4429

Closed
smsaladi opened this issue Apr 20, 2018 · 3 comments
Closed

customizable scrolling #4429

smsaladi opened this issue Apr 20, 2018 · 3 comments

Comments

@smsaladi
Copy link

@smsaladi smsaladi commented Apr 20, 2018

Jupyter lab scrolls past the end of the text document (all the way through a blank screen) by default, as suggested here #813

I understand the preference to view code at eye level, but I actually really dislike this as default. Often, I through to the end of a document to look for a block from the bottom up (when I know it's near the end) and then end up with a complete blank screen.

For reference, Atom doesn't scroll past through the last bit of text.

Is there a way to have a customization setting to change one's own installation? I don't mind the current setting being default, but it would be great to modify my own install. Happy to try contributing a fix (if someone can point me in the right direction)

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 20, 2018

Here is the line that causes that behavior:

scrollPastEnd: true,

I don't think it is exposed as an editor setting to JupyterLab, though it would make sense to expose it. @ian-r-rose knows a lot about exposing editor settings.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Apr 20, 2018

It should be relatively straightforward to expose this option in the CodeMirror section of the settings editor. I am less sure whether we would want to promote it to the abstract editor settings, but having it in codemirror-extension/schema would make good sense.

I think this is a nice issue for a new contributor. Generally, one would follow the same pattern as the theme and keyMap options in the codemirror-extension package.

@BobRatzi
Copy link

@BobRatzi BobRatzi commented Nov 18, 2018

So I am not all the familiar with the application but learning. The setting to change scrollPastEnd is exposed in the advanced editor/settings tab to be updated by the user.

codemirror/src/editor.ts - line 1122

I dont think it would be hard to add it to settings menu in a similar fashion to "Auto Close Brackets for Text Editor" but I dont know if that is something needed. Or if that will just start to overfill the menu option list.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants