Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/lab/tree/nb.ipynb no longer opens notebook #4502

Closed
consideRatio opened this issue May 1, 2018 · 13 comments
Closed

/lab/tree/nb.ipynb no longer opens notebook #4502

consideRatio opened this issue May 1, 2018 · 13 comments

Comments

@consideRatio
Copy link
Member

@consideRatio consideRatio commented May 1, 2018

I noticed that in between 0.31.12 and 0.32.0 somewhere, the ability for jupyterhub to open a view of a notebook file by visiting lab/tree/nb.ipynb for example vanished.

Using 0.32.0 (does not work)

https://mybinder.org/v2/gh/consideratio/jupyter-se-math-teacher/master?urlpath=lab%2Ftree%2Fsource%2Fgradient-descent%2Fgradient-descent.ipynb

Using 0.31.12 (works)

https://mybinder.org/v2/gh/consideratio/jupyter-se-math-teacher/mybinder-testing?urlpath=lab%2Ftree%2Fsource%2Fgradient-descent%2Fgradient-descent.ipynb


I looked through the 0.32.0 release notes, perhaps a PR like #4087 could have influenced this unintentionally?

@jzf2101 jzf2101 added the bug label May 1, 2018
@jzf2101
Copy link
Contributor

@jzf2101 jzf2101 commented May 1, 2018

FWIW I've observed this behavior as well on binder

Loading

@consideRatio
Copy link
Member Author

@consideRatio consideRatio commented May 1, 2018

I'm new to this code base, but have attempted to figure out what might have happened. So far my best guess is that the changes in #3687 did something, they seem to affect the /tree routing.

Is there another routing except /lab/tree that should start up something? In the classic notebook, you could write /terminals/1 to open a terminal, is there something similar in jupyterlab? That way I'd be able to test if this was related only to the /lab/tree routing.

Update 1

To inspect all changes in between 0.31.12 and 0.32.0 this link might come in handy: v0.31.12...v0.32.0

Update 2

I tried to reproduce this locally on my computer, but it works in v0.31.12 and v0.32.0 and v0.32.1...
Hmmm...

Loading

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 1, 2018

CC @afshin

Loading

@zieherf
Copy link

@zieherf zieherf commented May 5, 2018

I see the same behaviour on beta 2 (v0.32.1). When running jupyter-lab and pasting a url into the browser bar, the notebook opens. When launching jupyter-labhub within jupyterhub the notebook does not open. Any thoughts about where those differences may come from?

Loading

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 5, 2018

Loading

@consideRatio
Copy link
Member Author

@consideRatio consideRatio commented May 14, 2018

@FCoulombeau do you open up into jupyterlab if you do that? I didn't.

Loading

@FCoulombeau
Copy link

@FCoulombeau FCoulombeau commented May 14, 2018

@consideRatio I removed my comment when I realised that I was mistaking with bug #3966 which has been fixed. Sorry for the noise.

Issue #3966

Loading

@ckbhatt
Copy link

@ckbhatt ckbhatt commented May 14, 2018

Reporting same while upgrading from 0.31.8 to 0.32.1, lab running along with Jupyter hub.

Loading

@ckbhatt
Copy link

@ckbhatt ckbhatt commented May 29, 2018

screen shot 2018-05-28 at 11 51 02 pm

This is also reproducible by clicking on Try Jupyter Lab card on http://jupyter.org/try Earlier it used to open sample Lorenz.ipynb notebook in Jupyter lab as of today it does not though URL is pointing to Lorenz.ipynb

Loading

@zieherf
Copy link

@zieherf zieherf commented Jun 4, 2018

Any update on this unintended behavior? Even some workaround would be appriciated.
Thanks, Franz

Loading

@afshin afshin self-assigned this Jun 7, 2018
@afshin
Copy link
Member

@afshin afshin commented Jun 7, 2018

Thanks for the report. The combination of workspaces and tree paths is an unresolved problem. This is a regression that happened independent of that complexity. We will resolve this for the next release, but the URLs may end up looking different from the current ones because of the additional routing constraints we have.

Loading

@afshin afshin added this to the Beta 3 milestone Jun 7, 2018
@afshin
Copy link
Member

@afshin afshin commented Jun 7, 2018

Loading

@jzf2101
Copy link
Contributor

@jzf2101 jzf2101 commented Jul 1, 2018

Docs are in #4780

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

8 participants