Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Notebook and Keyboard Shortcut settings contain invalid json #4591

Closed
goerz opened this issue May 16, 2018 · 2 comments · Fixed by #4595
Closed

Default Notebook and Keyboard Shortcut settings contain invalid json #4591

goerz opened this issue May 16, 2018 · 2 comments · Fixed by #4595

Comments

@goerz
Copy link

@goerz goerz commented May 16, 2018

This was already mentioned in #3643, but that issue was closed without resolving the problem.

In the "Advanced Settings Editor", "Notebook", if I copy the content of "System Defaults" and paste it into "User Overrides", I get a syntax error. The reason is that the commas between the different configuration blocks are missing.

The same thing happens for "Keyboard Shortcuts"

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 16, 2018

Thanks for the report!

@ian-r-rose ian-r-rose added this to the Beta 3 milestone May 16, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 16, 2018

It seems this is not just for the notebook and keyboard shortcuts, but all settings. The individual entries of the JSON-schema are not separated by a ",", and as such the default schemas are invalid. cc @afshin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants