Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Manager doesn't recognise when an install failed #5042

Closed
dhirschfeld opened this issue Aug 3, 2018 · 8 comments · Fixed by #5147
Closed

Extension Manager doesn't recognise when an install failed #5042

dhirschfeld opened this issue Aug 3, 2018 · 8 comments · Fixed by #5147
Assignees
Milestone

Comments

@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Aug 3, 2018

As it says in the title. In my particular case the install failed with JavaScript heap out of memory but in the UI there was no indication of failure and the blue bar kept moving across.

Not sure if that's the case with all install errors or just with the particular one I observed.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 3, 2018

@jasongrout jasongrout added this to the 0.34 milestone Aug 3, 2018
@hadim
Copy link
Contributor

@hadim hadim commented Aug 5, 2018

I confirmed this bug while installing the jlab git extension (the bug causing the installation failure as since been fixed).

@blink1073 blink1073 removed this from the 0.34 milestone Aug 13, 2018
@blink1073 blink1073 added this to the 0.35 milestone Aug 13, 2018
@vidartf vidartf self-assigned this Aug 13, 2018
@vidartf
Copy link
Member

@vidartf vidartf commented Aug 13, 2018

I'll have a look at this tomorrow!

@vidartf
Copy link
Member

@vidartf vidartf commented Aug 16, 2018

Can you confirm that the install failure triggers an exception on the JS side? If so, a fix should be available in #5147. If not, I'd appreciate a stack trace from the python side if available!

@vidartf
Copy link
Member

@vidartf vidartf commented Sep 3, 2018

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Sep 3, 2018

@vidartf - the JavaScript heap out of memory was a JS exception.

I'm not sure what you mean by stack trace from the python side? JupyterLab extensions are npm/JS packages so where would a python exception be thrown?

@vidartf
Copy link
Member

@vidartf vidartf commented Sep 4, 2018

@dhirschfeld I meant on the browser side, sorry for the confusion. The error on the server side should have cause an exception to be thrown in the browser as well (which should now be handled).

@dhirschfeld
Copy link
Member Author

@dhirschfeld dhirschfeld commented Sep 4, 2018

There wasn't anything visible but I didn't check the console.

I haven't checked since but I'll assume it was fixed in #5147. If it does still happen I can always open a new issue for it and I'll make sure to capture more useful info next time!

@blink1073 blink1073 removed this from the 0.35 milestone Sep 5, 2018
@blink1073 blink1073 added this to the 1.0 milestone Sep 5, 2018
@blink1073 blink1073 mentioned this issue Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants