Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipe delimiter for table view of CSV #5112

Closed
citizenrich opened this issue Aug 12, 2018 · 1 comment
Closed

Add pipe delimiter for table view of CSV #5112

citizenrich opened this issue Aug 12, 2018 · 1 comment

Comments

@citizenrich
Copy link

@citizenrich citizenrich commented Aug 12, 2018

The current delimiters supported in the dropdown for table view of CSV are commas, semicolons, and tab. Is there interest in supporting pipe (|) delimitation?

@blink1073 blink1073 added this to the 0.34 milestone Aug 12, 2018
@blink1073 blink1073 removed this from the 0.34 milestone Aug 12, 2018
@blink1073 blink1073 added this to the 1.0 milestone Aug 12, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 12, 2018

Hi @citizenrich, good suggestion! I'm going to mark this as a good first issue:

const DELIMITERS = [',', ';', '\t'];

const LABELS = [',', ';', 'tab'];

blink1073 added a commit that referenced this issue Aug 14, 2018
…5128)

* enhancement to add pipe delimiter in table view of csv

* Update toolbar.ts

* Adding pipe delimiter to table view of csvviewer
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants