Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract MathJaxTypesetter into library #5257

Closed
vidartf opened this issue Sep 3, 2018 · 5 comments · Fixed by #5259
Closed

Extract MathJaxTypesetter into library #5257

vidartf opened this issue Sep 3, 2018 · 5 comments · Fixed by #5259

Comments

@vidartf
Copy link
Member

@vidartf vidartf commented Sep 3, 2018

It would be nice to be able to import/use the MathJaxTypesetter without getting a dependency on @jupyterlab/application. This could be achieved if the class definition was extracted out from the extension package, into a separate library package.

On a similar note, would it be reasonable to move materialcolors.css from @jupyterlab/application to @jupyterlab/apputils? As far as I can tell from the dependency map at https://jlab.readthedocs.io/en/debug-rtd/extensions_dev.html, this should not add any additional dependencies.

@vidartf
Copy link
Member Author

@vidartf vidartf commented Sep 3, 2018

PS: If there is consensus for this, I'd be happy to do the legwork in a PR.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 3, 2018

Sounds good Vidar, yes, please!

@vidartf
Copy link
Member Author

@vidartf vidartf commented Sep 3, 2018

@blink1073 On both counts (typesetter and materialcolors)?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 3, 2018

Yup!

@vidartf
Copy link
Member Author

@vidartf vidartf commented Sep 3, 2018

Actually it should be both, otherwise apputils has an implicit dependency on application (otherwise there will be missing CSS vars, as e.g. commandpalette.css uses md vars).

@blink1073 blink1073 mentioned this issue Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants