Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen should be dark when theme is dark #5338

Closed
jasongrout opened this issue Sep 18, 2018 · 3 comments
Closed

Splash screen should be dark when theme is dark #5338

jasongrout opened this issue Sep 18, 2018 · 3 comments

Comments

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 18, 2018

It is jarring right now to have a white splash screen that then fades to a dark theme. It seems that the theming info is available when the splash screen is displayed. It would be great if we can have two versions of the splash colors, one for light themes and one for dark themes.

@jasongrout jasongrout added this to the 1.0 milestone Sep 18, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Sep 18, 2018

CC @tgeorgeux.

Minimally, I did this:

diff --git a/packages/apputils-extension/style/splash.css b/packages/apputils-extension/style/splash.css
index 9db3f3210..843f71ba2 100644
--- a/packages/apputils-extension/style/splash.css
+++ b/packages/apputils-extension/style/splash.css
@@ -13,7 +13,7 @@
   background-position: center 40%;
   background-repeat: no-repeat;
   background-size: cover;
-  background-color: white;
+  background-color: var(--jp-layout-color1); /* white; */
 }
 
 .splash-fade {

Of course, this doesn't quite work, since a theme might have a really weird layout color. Instead, we should have the recommended dark background explicit.

Loading

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Sep 18, 2018

This is actually going to be a bit trickier. It seems that the theme is not loaded when the splash screen is put on the page, and actually even changing the background to the layout color only changes it to the background just after it loads (i.e., the variable is defined just after loading).

Loading

jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Sep 19, 2018
…lash screen.

Use this parameter when a theme changes to show a splash screen matching the theme (light for light themes, dark for dark themes).

Fixes jupyterlab#5338
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Sep 19, 2018

Fixed in #5339.

Loading

@afshin afshin closed this in #5339 Sep 21, 2018
@blink1073 blink1073 mentioned this issue Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants