Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark scheme: Improve code completion dropbox selector contrast #5349

Closed
alexveden opened this issue Sep 21, 2018 · 3 comments · Fixed by #5364
Closed

Dark scheme: Improve code completion dropbox selector contrast #5349

alexveden opened this issue Sep 21, 2018 · 3 comments · Fixed by #5364

Comments

@alexveden
Copy link

@alexveden alexveden commented Sep 21, 2018

Describe the bug
Could you please make more contrast selection row in code completion dropbox (at TAB press)?

image

  • OS: Ubuntu LTS 16.04
  • Browser Chrome Version 69.0.3497.100
  • JupyterLab 0.34.11
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 21, 2018

Thanks for the report!

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Sep 26, 2018

If on select we change the font color on focus to "--jp-ui-inverse-font-color1" it will show up more clearly.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 26, 2018

Would you mind adding this comment to the PR as a review comment: #5364 ?

tgeorgeux added a commit that referenced this issue Sep 28, 2018
Fix issue #5349 by using a darker color as background when row selected
@jasongrout jasongrout removed this from the 1.0 milestone Sep 28, 2018
@jasongrout jasongrout added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this issue Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.