Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status bar to core #5352

Closed
saulshanabrook opened this issue Sep 21, 2018 · 6 comments · Fixed by #5508
Closed

Add status bar to core #5352

saulshanabrook opened this issue Sep 21, 2018 · 6 comments · Fixed by #5508
Assignees
Milestone

Comments

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Sep 21, 2018

Whenever it's ready we should merge https://github.com/jupyterlab/jupyterlab-statusbar into core and make the sure the original git commit authors retain that author status on the commits.

@saulshanabrook
Copy link
Member Author

@saulshanabrook saulshanabrook commented Oct 5, 2018

@ian-r-rose I know there has been some prior work on how to do this sort of merge, but wanted to throw the idea of using git subtree to add the other repo to this one then adding commits on top of that to do any cleaup that needs to happen.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 5, 2018

Yep, that was my plan. I have done that before, but every time I do it I have to re-learn it 😄

@saulshanabrook
Copy link
Member Author

@saulshanabrook saulshanabrook commented Oct 5, 2018

Yep that makes sense. I am interested in seeing how it is done, so if it works could you ping me when you are going to do it and maybe we could do a screen share?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 5, 2018

Sure thing. We can try to stumble through it together.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Oct 5, 2018

Is the plan to move the individual status bar items to the extensions that deal with that stuff. For example, would notebook related things get moved to the notebook extension etc? That way the core status bar extension could just be the core APIs that other extensions use? It may not be that simple, but wondering if that makes sense.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 5, 2018

It think that makes sense. I think I'll have a better idea of it once we get the ball rolling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants