Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the share command into its own plugin to allow it to be overridden. #5388

Closed
afshin opened this issue Sep 27, 2018 · 3 comments · Fixed by #5460
Closed

Move the share command into its own plugin to allow it to be overridden. #5388

afshin opened this issue Sep 27, 2018 · 3 comments · Fixed by #5460
Labels
enhancement good first issue help wanted pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@afshin
Copy link
Member

afshin commented Sep 27, 2018

In order to allow custom building of URLs in the file browsers "Copy Shareable Link" functionality, we should move the 'filebrowser:share-main' command's implementation and addition to the command registry into a small plugin that can be disabled in specialized environments.

cf. https://gitter.im/jupyterlab/jupyterlab?at=5bacc22e56877c463a90c648
cc: @minrk

@minrk
Copy link
Contributor

minrk commented Sep 27, 2018

Thanks! cross-ref jupyterhub/jupyterhub#2017 where it would be handy to make 'shareable link' copy the /hub/user-redirect link instead of the local-only url

@vidartf
Copy link
Member

vidartf commented Sep 27, 2018

Would it be best to have this as a separate extension, or a separate plugin only (keeping it in the original extension)?

@afshin afshin changed the title Move the share command into its own extension to allow it to be overridden. Move the share command into its own plugin to allow it to be overridden. Sep 27, 2018
@afshin
Copy link
Member Author

afshin commented Sep 27, 2018

Sorry for being imprecise @vidartf, I meant a JupyterLabPlugin and should have called it a plugin. I updated the issue.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement good first issue help wanted pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants