Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Phosphor tab dragging behavior #5406

Closed
tgeorgeux opened this issue Sep 29, 2018 · 5 comments · Fixed by #6454
Closed

Change Phosphor tab dragging behavior #5406

tgeorgeux opened this issue Sep 29, 2018 · 5 comments · Fixed by #6454

Comments

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Sep 29, 2018

I wanted to bring attention to the issue I opened on the Phosphor repo about tab docking.

phosphorjs/phosphor#360

I am not 100% sure where the line is drawn between phosphor's and jupyterLab's execution of these so if I need to duplicate parts of this let me know please.
@Zsailer @jasongrout @afshin @blink1073 @saulshanabrook @ian-r-rose @sccolbert

Thanks everybody have a great weekend!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Oct 4, 2018

Thank you @tgeorgeux and @Zsailer for working on this. We went over the main results this afternoon and it looks like there are some actions we will be able to take based on this. One though - maybe @tgeorgeux you can present this at the team meeting next Wednesday to bring other folks up to speed?

That would be a good way to get into the question of implementation.

@jasongrout jasongrout removed this from the Future milestone Feb 28, 2019
@jasongrout jasongrout added this to the 1.0 milestone Feb 28, 2019
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Apr 18, 2019

I've had an open PR for this on phosphor for a while.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 22, 2019

For reference, the open PR in phosphor is phosphorjs/phosphor#365

I commented there on several ways to move forward with pushing these changes to a jlab prerelease.

I think we really need to have a prerelease with these changes so that we can test them out a bit before a final 1.0 release.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented May 22, 2019

TODO:

@jasongrout jasongrout changed the title Phosphor Docking Tests at JupyterCon Change phosphor tab dragging behavior May 25, 2019
@jasongrout jasongrout changed the title Change phosphor tab dragging behavior Change Phosphor tab dragging behavior May 25, 2019
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 1, 2019
This pulls in the tab drop zone change in @phosphor/widgets 1.7.0.

Fixes jupyterlab#5406
@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants