Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should allow user to style the codemirror selection #5528

Closed
futurist opened this issue Oct 26, 2018 · 1 comment · Fixed by #5529
Closed

Should allow user to style the codemirror selection #5528

futurist opened this issue Oct 26, 2018 · 1 comment · Fixed by #5529

Comments

@futurist
Copy link
Contributor

@futurist futurist commented Oct 26, 2018

Describe the bug
Now it's lack the config options to style the codemirror selection, there are commonly used addons for codemirror to style these:

selection/active-line.js
selection/mark-selection.js
selection/selection-pointer.js

Expected behavior
The selection addons for codemirror should be included and set to a basic default config options.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • JupyterLab [<=0.35]
@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 26, 2018

Looks good to me! cc @tgeorgeux for style input.

@blink1073 blink1073 added this to the 1.0 milestone Oct 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants