Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-save interval configuration #5619

Closed
katsar0v opened this issue Nov 13, 2018 · 3 comments
Closed

Auto-save interval configuration #5619

katsar0v opened this issue Nov 13, 2018 · 3 comments

Comments

@katsar0v
Copy link
Contributor

@katsar0v katsar0v commented Nov 13, 2018

Is there an option to set the interval of the auto-save feature? E.g. two minutes vs 30 seconds or 5 minutes. Would be also really nice to have, if not yet implemented.

@vidartf
Copy link
Member

@vidartf vidartf commented Nov 13, 2018

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Nov 13, 2018

I think this would be a good target for an advanced new contributor. We currently allow the user to enable/disable autosaving via the document manager, but not customize the interval. Here is where autosaving can be turned on or off:

/**
* Whether to autosave documents.
*/
get autosave(): boolean {
return this._autosave;
}
set autosave(value: boolean) {
this._autosave = value;
// For each existing context, start/stop the autosave handler as needed.
this._contexts.forEach(context => {
const handler = Private.saveHandlerProperty.get(context);
if (value === true && !handler.isActive) {
handler.start();
} else if (value === false && handler.isActive) {
handler.stop();
}
});
}

And here is where that is exposed as a setting:

const autosave = settings.get('autosave').composite as boolean | null;
docManager.autosave =
autosave === true || autosave === false ? autosave : true;
app.commands.notifyCommandChanged(CommandIDs.toggleAutosave);

One would implement a very similar new property on the document manager called autosaveInterval that the user could set via the settings system in docmanager-extension. Feel free to ask here if you have any questions.

@vidartf, I don't think that would work for lab.

@perrywky
Copy link
Contributor

@perrywky perrywky commented Nov 17, 2018

I can help with this, but is there any UX suggestion? what about a modal prompted to user to input an arbitrary interval seconds?

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants