Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainmenu-extension leaks memory #5664

Closed
PEERCRED opened this issue Nov 24, 2018 · 1 comment · Fixed by #5686
Closed

mainmenu-extension leaks memory #5664

PEERCRED opened this issue Nov 24, 2018 · 1 comment · Fixed by #5686
Assignees
@ian-r-rose
Labels
bug pkg:mainmenu status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
1.0

Comments

@PEERCRED
Copy link

PEERCRED commented Nov 24, 2018 •
edited

Describe the bug
mainmenu-extension causes memory leaks by holding references to disposed widgets

To Reproduce

  1. Open a big pdf-file.
  2. Close the tab with the pdf-file.

Now you may open Firefox Developer Memory tool, take a snapshot and see the JSString with base64-encoded content of the pdf-file being kept in memory.

tabmenu:activate-##### suggests that mainmenu-extension is to blame.

Possible fix
Listen to the widget's being added disposed signal and dispose the command.

Screenshots
image
image
@ian-r-rose ian-r-rose mentioned this issue Nov 27, 2018
Merged
@jasongrout jasongrout added this to the 1.0 milestone Nov 27, 2018
@ian-r-rose
Copy link
Member

Thanks for the report @PEERCRED, a fix for this is in #5686.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ian-r-rose ian-r-rose

Labels
bug pkg:mainmenu status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Properly dispose of text model on disposal. ian-r-rose/jupyterlab
4 participants
@ellisonbg @jasongrout @ian-r-rose @PEERCRED