Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Bar should be optional and toggled from menu or similar #5982

Closed
mbektas opened this issue Feb 13, 2019 · 2 comments
Closed

Status Bar should be optional and toggled from menu or similar #5982

mbektas opened this issue Feb 13, 2019 · 2 comments

Comments

@mbektas
Copy link
Member

@mbektas mbektas commented Feb 13, 2019

There is no way to hide the status bar to save on screen real estate. A menu item can be added to toggle it.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Feb 13, 2019

Sounds good. I think it makes sense to have a menu entry in the view menu to toggle this status.

I can imagine that a good way to tackle this is to

  1. Make a new command to do this, similar to the "Show Left Sidebar" command at

    app.commands.addCommand(command, {
    label: args => 'Show Left Sidebar',
    execute: () => {
    if (app.shell.leftCollapsed) {
    app.shell.expandLeft();
    } else {
    app.shell.collapseLeft();
    if (app.shell.currentWidget) {
    app.shell.activateById(app.shell.currentWidget.id);
    }
    }
    },
    isToggled: () => !app.shell.leftCollapsed,
    isVisible: () => !app.shell.isEmpty('left')
    });
    palette.addItem({ command, category });

  2. Add it to the menu, like the notebook adds items to the view menu in

    mainMenu.viewMenu.addGroup(collapseGroup, 10);

  3. Make it a setting that is saved for the status bar extension (a little more complicated, but basically adding a new schema file for the status bar, and then putting logic into the command to change the setting when the status bar is toggled).

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Feb 13, 2019

Tagging as a good first issue - to do everything above is probably an advanced good first issue.

@jasongrout jasongrout added this to the Future milestone Feb 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants