Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and replace menu item #6322

Closed
bsyouness opened this issue May 7, 2019 · 4 comments · Fixed by #6350
Closed

Find and replace menu item #6322

bsyouness opened this issue May 7, 2019 · 4 comments · Fixed by #6350
Assignees
Milestone

Comments

@bsyouness
Copy link
Contributor

@bsyouness bsyouness commented May 7, 2019

@aschlaep

The issue
"Find and replace" isn't an active menu item while in a notebook. Also, although active in a text document, it spins up the older version of "find and replace".

To Reproduce
Steps to reproduce the behavior:

  1. Go to the "Edit" menu
  2. Go to "Find and Replace"

Expected behavior
The menu item "find and replace" should be active whenever a notebook, text or markdown file is open and should trigger the new "find and replace".

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 8, 2019

Can you try the latest prerelease, 1.0a3? I think this has been fixed.

@bsyouness
Copy link
Contributor Author

@bsyouness bsyouness commented May 8, 2019

I tried the latest prerelease. It hasn't.

@jasongrout jasongrout added this to the 1.0 milestone May 8, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 8, 2019

I just confirmed that. Looks like we missed changing that menu item. And it looks like the command palette item for the new find and replace still just says "Find..." instead of "Find and Replace...".

CC @aschlaep

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants