Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-W on windows closes browser window, not JupyterLab tab #6357

Closed
ivanov opened this issue May 15, 2019 · 6 comments
Closed

Ctrl-W on windows closes browser window, not JupyterLab tab #6357

ivanov opened this issue May 15, 2019 · 6 comments

Comments

@ivanov
Copy link
Member

@ivanov ivanov commented May 15, 2019

Describe the bug
Accel-W is meant to close a JupyterLab tab, and on Windows Accel maps to Ctrl.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browsers: Chrome 74.0.3729.131, Firefox 66.0.5
  • JupyterLab master b58e1dd

We should do some subset of - providing an alternative keyboard shortcut on windows for closing JupyterLab tabs by default, and also at least not display the misleading ctrl-w shortcut on windows, since that will close the whole browser tab, not just a jupyterlab tab within that tab.

@ivanov
Copy link
Member Author

@ivanov ivanov commented May 16, 2019

in diagram-codesprint#6, @corvinb also identified that this is an issue for MacOS 10.14.4 for Chrome and Safari.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 23, 2019

Looks like Accel W is a bad shortcut for closing a tab. Any suggestions for a better one?

@vidartf
Copy link
Member

@vidartf vidartf commented May 23, 2019

Alt + W ?

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 23, 2019

According to https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts, Alt+W seems available.

On my mac, Alt+W inputs the greek sigma: ∑

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 23, 2019

Let's make this a good first issue to change the keyboard shortcut to Alt+W, which seems like it may not do anything in a windows browser either.

Fixing this issue is changing Accel W to Alt W here:

{
"command": "application:close",
"keys": ["Accel W"],
"selector": ".jp-Activity"
},

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants