Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JupyterHub Integration #6428

Closed
blink1073 opened this issue May 28, 2019 · 12 comments
Closed

Better JupyterHub Integration #6428

blink1073 opened this issue May 28, 2019 · 12 comments

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 28, 2019

I propose that we have better integration with JupyterHub. In the short run, we add a flag to labhubapp that the front end uses to determine which connection loss dialog to show (cf #6399), and whether to add the commands/menu items that are currently provided by https://github.com/jupyterhub/jupyterlab-hub.

The next logical step would be to augment jupyterhub-singleuser to provide page_config_data and deprecate the use of labhubapp.

@blink1073 blink1073 added this to the 1.0 milestone May 28, 2019
@blink1073 blink1073 self-assigned this May 28, 2019
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 28, 2019

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 28, 2019

cc @minrk

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented May 28, 2019

Love it!

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 28, 2019

👊

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 29, 2019

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 29, 2019

@athornton
Copy link
Member

@athornton athornton commented May 29, 2019

Very nice. Thumbs up. This in fact addresses a behavior related to reporting of kernel failure I was going to open an issue for once I had sufficient reproducibility. Plus it'd be nice to be able to get rid of labhub. (Also please feel free to cannibalize https://github.com/lsst-sqre/jupyterlab-savequit , which at our site, pretty much everyone uses rather than the Hub menu)

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 30, 2019

Quick note to self: no changes are needed to jhub, we can just add the page config ourselves if the app has a hub_prefix property.

@vidartf
Copy link
Member

@vidartf vidartf commented May 31, 2019

I have ~0 experience with hub, so I have no idea what this issue is implying. What would the changes to jupyterlab itself be?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 31, 2019

We would update our extension to inject more page_config conditionally, and then add logic application-extension that runs in the presence of that page config.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 31, 2019

@athornton, thanks for the pointer! I'm wary of adding too much logic up front that might not be wanted in all contexts. I'd prefer to start small.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants