Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing tracebacks in CLI #6499

Closed
blink1073 opened this issue Jun 7, 2019 · 9 comments · Fixed by #6567
Closed

Avoid showing tracebacks in CLI #6499

blink1073 opened this issue Jun 7, 2019 · 9 comments · Fixed by #6567

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 7, 2019

We should not be showing the user full tracebacks in CLI.

  • It could extend beyond the scroll limit of their terminal
  • It can be overwhelming

I think we should follow the lead of npm and yarn and create an error file that can be easily copied into an issue or given to an administrator.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 8, 2019

We should also include as part of a build failure the app directory and a note that they may be able to run jupyter lab clean && jupyter lab build to fix the issue. A successful build should delete the error file, the same way it does with npm.

@blink1073 blink1073 removed this from the 1.1 milestone Jun 8, 2019
@blink1073 blink1073 added this to the 1.0 milestone Jun 8, 2019
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 8, 2019

@vidartf, are you up for tackling this one?

@vidartf
Copy link
Member

@vidartf vidartf commented Jun 11, 2019

If I can find some time. When is it needed by? :)

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 12, 2019

The 17th. 😀

@vidartf
Copy link
Member

@vidartf vidartf commented Jun 13, 2019

Some related work in #6567. What we can do on top of that one is to add a file logger with debug log level, and only delete that log right before a successful exit.

@vidartf
Copy link
Member

@vidartf vidartf commented Jun 13, 2019

BTW, when you say CLI here, which entry points do you mean? I'm thinking that install/uninstall/build are the important ones?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 13, 2019

Yeah those sound good for now.

@vidartf
Copy link
Member

@vidartf vidartf commented Jun 14, 2019

I think the PR should now resolve this issue as well.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants