Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Usage Cleanup #6530

Closed
1 task done
blink1073 opened this issue Jun 10, 2019 · 5 comments
Closed
1 task done

CSS Usage Cleanup #6530

blink1073 opened this issue Jun 10, 2019 · 5 comments

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 10, 2019

Follow up to #6395

I'll flesh this out more tomorrow:

  • add style fields to phosphor packages with styles
  • template index.css ( in examples too)
    -- need to declare which other deps to import (like font-awesome)
    -- then we add them in dependency order
    -- then we add ./base.css
  • Specify where css file was generated from
@blink1073 blink1073 self-assigned this Jun 10, 2019
@blink1073 blink1073 added this to the 1.0 milestone Jun 10, 2019
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 10, 2019

Note: we can't extract css in general because the static url is dynamic on base_url (in jhub for example).

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 10, 2019

Should this block an alpha, or are you okay with us releasing an alpha tonight?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 10, 2019

I think if Brian takes master for a spin and doesn't see anything glaring we should release alpha and rc before this.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 11, 2019

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants